On Tue, Oct 7, 2008 at 3:16 PM, John W. Linville <linville@xxxxxxxxxxxxx> wrote: > On Tue, Oct 07, 2008 at 03:15:29AM -0400, Christoph Hellwig wrote: >> On Tue, Oct 07, 2008 at 08:21:56AM +0200, Holger Schurig wrote: >> > > I don't want these macros eithers but I NACK any patches with >> > > cursing in the commit logs. >> > >> > I fully agree. There's no need to speak about "crap" when >> > changing other people's code. In some cultures thats quite >> > insulting. >> >> Well, it is crap. Looks at it objectively. It's a perfectly fine >> description and most of us use it perfectly happily for our own code, >> too. > > I agree that this is at worst a little bit rude. The patch should be > rejected or merged on its own basis, although I do reserve the right > to edit a changelog from time to time... :-) Appreciated. > Now, can we discuss the patch rather than Johannes' intemperate > word choice? With Johannes permissions I will split the patch into chunks first so I can take smaller steps second it will better fit into patches I have in pipe. Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html