On Tue, 2021-12-07 at 16:23 -0800, Joe Perches wrote:
> On Tue, 2021-12-07 at 15:58 -0700, David Mosberger-Tang wrote:
> > On 12/6/21 6:33 PM, Joe Perches wrote:
> >
> > > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote:
> > > > Add missing newline in pr_err() message.
> > > []
> > > > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
> > > []
> > > > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data)
> > > > struct wilc *wilc = user_data;
> > > >
> > > > if (wilc->close) {
> > > > - pr_err("Can't handle UH interrupt");
> > > > + pr_err("Can't handle UH interrupt\n");
> > > Ideally this would use wiphy_<level>:
> > >
> > > wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n");
> >
> > Sure, but that's orthogonal to this bug fix.
>
> Of course.
>
> > I do have a "cleanups"
> > branch with various cleanups of this sort. I'll look into fixing pr_*()
> > calls in the cleanups branch (there are several of them, unsurprisingly).
>
> netdev_<level> -> wiphy_<level> conversions too where feasible please.
OK, I made a note for that, too, thanks.
--david
