Search Linux Wireless

Re: [PATCH 2/2] wilc1000: Fix missing newline in error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/6/21 6:33 PM, Joe Perches wrote:

On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote:
Add missing newline in pr_err() message.
[]
diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
[]
@@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data)
  	struct wilc *wilc = user_data;
if (wilc->close) {
-		pr_err("Can't handle UH interrupt");
+		pr_err("Can't handle UH interrupt\n");
Ideally this would use wiphy_<level>:

		wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n");

Sure, but that's orthogonal to this bug fix.  I do have a "cleanups" branch with various cleanups of this sort.  I'll look into fixing pr_*() calls in the cleanups branch (there are several of them, unsurprisingly).


  --david





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux