On Fri, 2020-05-29 at 20:10 +0530, Sathishkumar Muruganandam wrote: > On 2020-05-29 18:16, Johannes Berg wrote: > > On Fri, 2020-05-29 at 17:59 +0530, Sathishkumar Muruganandam wrote: > > > Yes, currently only tx encap support is added and rx decap support is > > > in > > > progress to do TKIP MIC error reporting to userspace via > > > cfg80211_michael_mic_failure(). > > > > Yes, but can you actually call that? It requires a netdev. I don't > > think > > you can easily get it from the vif? > > > > Yes, that's right. Currently the plan is to add new mac80211 api for rx > decap where > we can call cfg80211_michael_mic_failure() and not called directly from > driver. Sure, that sounds fine. Really what I was saying is that we should have that together, not just this patch that allows TKIP offload, but then nothing that actually makes that working properly/safely. > Whether we can expose netdev to driver for doing such cfg80211 call ? I've always worried that if we expose the netdev we'll just get all kinds of messy things happening in the driver :) But maybe not. I guess it doesn't make a big difference. johannes
