On 2020-05-29 17:40, Johannes Berg wrote:
On Fri, 2020-05-29 at 17:38 +0530, Sathishkumar Muruganandam wrote:
> I don't think it can. It doesn't have all the necessary information to
> call cfg80211_michael_mic_failure(), as far as I can tell.
Ath11k HW has capability of reporting TKIP MIC error when hw encap is
enabled as well, so TKIP encryption shall be enabled.
Maybe so. But it cannot tell wpa_supplicant about MIC errors, and so
that cannot do countermeasures, so something isn't right.
Shall we have a ieee80211_hw_flags for the driver to advertise TKIP
MIC
error reporting capability when hw encap is enabled ?
TKIP bring-up will be disabled for the drivers which doesn't have the
capability.
That would be better, since for TKIP it's actually more tricky and
requires more work.
But mostly I was thinking that you should make it possible for ath11k
to
actually report the MIC errors up to userspace. Right now I don't think
it can, because it doesn't have the netdev pointer?
Yes, currently only tx encap support is added and rx decap support is in
progress to do TKIP MIC error reporting to userspace via
cfg80211_michael_mic_failure().
With NL80211_CMD_MICHAEL_MIC_FAILURE, hostapd will be able to do TKIP
counter-measures.
Thanks,
Sathishkumar
