On 2020-05-26 18:14, Johannes Berg wrote:
On Fri, 2020-04-24 at 15:05 +0530, Sathishkumar Muruganandam wrote:
TKIP was disabled on encap offload mode since if TKIP MIC error
reporting is not capable by the driver using encap offload mode,
then TKIP countermeasures wont work.
Enabling back TKIP bring-up in encap offload mode to leave the
control with the driver to disable hw encap when it is not capable
of TKIP MIC error reporting.
So how can the driver do TKIP MIC error reporting?
I don't think it can. It doesn't have all the necessary information to
call cfg80211_michael_mic_failure(), as far as I can tell.
Ath11k HW has capability of reporting TKIP MIC error when hw encap is
enabled as well, so TKIP encryption shall be enabled.
I'm not applying this until I see at least the *ability* for drivers to
do it. I mean, I don't really want to worry about your driver's
correctness, but if you then turn around and realize that you *cannot*
actually implement the right behaviour, that's no good either.
Shall we have a ieee80211_hw_flags for the driver to advertise TKIP MIC
error reporting capability when hw encap is enabled ?
TKIP bring-up will be disabled for the drivers which doesn't have the
capability.
--
Sathishkumar
