On 5/22/20 6:49 AM, Kalle Valo wrote:
And did the "bad" performance even have any real visible changes to the
user? IMHO this "bad" performance is small price to pay from getting
WPA3 supported out-of-box, especially when the data throughput is
unaffected.
Kalle,
The only bad effect is to consume 2-3 times more CPU than used if the firmware
handles encryption. On a modern system, the effect is negligible; however, these
cards are found only on older systems that have uni-processors.
I have reread the mac80211 documentation (comments in code at least), and it
appears that it should be possible to set MFP_CAPABLE unconditionally, and use
the set_key() callback to let mac80211 know if the driver/firmware will handle
encryption. The module parameter could be removed; however, I favor leaving it
in case of broken hardware.
@Rui: I will send you a new patch for testing.
Larry
