On 5/21/20 3:23 PM, Rui Salvaterra wrote:
On Thu, 21 May 2020 at 20:19, Rui Salvaterra <rsalvaterra@xxxxxxxxx> wrote:
Sure, I'll give it a spin. I'm now compiling the kernel for the laptop
with the other b43 card (BCM4311).
Nope, kmsg is clean. I'm pretty sure the condition is evaluating to
false because we do have the firmware, it's just that the crypto
engine doesn't support the required algo.
Is hardware encryption an all-or-nothing thing in mac80211? Wouldn't
it be possible use the hardware as much as possible and fall back to
software only for the unsupported features? (I guess the answer is
"no, because the firmware gets in the way", but I had to ask.)
My first failure indicates the mac80211 needs to know from the start that
software encryption is to be used. The only places that the driver makes note of
the nohwcrypt is in b43_op_set_key() where it returns -ENOSPC, and our new one
where MFP_CAPABLE is set. Otherwise, the packet flags indicate that encryption
is not needed.
Larry
