Search Linux Wireless

Re: [PATCH 1/1] mac80211: filter probes in ieee80211_rx_mgmt_probe_resp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2008-08-05 at 18:21 +0300, Tomas Winkler wrote:

> >> Probes are filtered on destination address not on BSSID, to exclude
> >> probe responses not directed to the station.
> >> bss_info treats any BSSID this is what creates the bss list after all
> >> if I'm not mistaken.
> >
> > Eh, right, of course, not sure why I got confused there. Still though,
> > adding a few lines of comments would be nice. If we did that every time
> > we changed a function, we'd have documentation for all functions in no
> > time ;) Oh well...
> >
> I agree, I haven't added any function in this patch so I'm not sure
> it's appropriate to add comments within this patch.
> The statement I've  moved is already commented.
> I can comment the function in a different patch.

Works for me, I don't really care too much either way.

I'm just thinking that when we change behaviour of a function or similar
we could take the opportunity to document the (new) behaviour. Not too
important in this case I guess.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux