On Tue, 2008-08-05 at 10:14 +0300, Tomas Winkler wrote: > On Sun, Aug 3, 2008 at 9:14 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Sun, 2008-08-03 at 14:32 +0300, Tomas Winkler wrote: > >> This patch moves filtering statement from ieee80211_rx_bss_info > >> which is called for both beacon and probe to ieee80211_rx_mgmt_probe_resp > >> and save few cycles in beacon parsing. > > > > Sounds alright to me, but maybe we should then document that > > rx_bss_info() only expects data for the right BSSID? > > Probes are filtered on destination address not on BSSID, to exclude > probe responses not directed to the station. > bss_info treats any BSSID this is what creates the bss list after all > if I'm not mistaken. Eh, right, of course, not sure why I got confused there. Still though, adding a few lines of comments would be nice. If we did that every time we changed a function, we'd have documentation for all functions in no time ;) Oh well... johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
