On Tue, Aug 5, 2008 at 12:09 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Tue, 2008-08-05 at 10:14 +0300, Tomas Winkler wrote: >> On Sun, Aug 3, 2008 at 9:14 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> > On Sun, 2008-08-03 at 14:32 +0300, Tomas Winkler wrote: >> >> This patch moves filtering statement from ieee80211_rx_bss_info >> >> which is called for both beacon and probe to ieee80211_rx_mgmt_probe_resp >> >> and save few cycles in beacon parsing. >> > >> > Sounds alright to me, but maybe we should then document that >> > rx_bss_info() only expects data for the right BSSID? >> >> Probes are filtered on destination address not on BSSID, to exclude >> probe responses not directed to the station. >> bss_info treats any BSSID this is what creates the bss list after all >> if I'm not mistaken. > > Eh, right, of course, not sure why I got confused there. Still though, > adding a few lines of comments would be nice. If we did that every time > we changed a function, we'd have documentation for all functions in no > time ;) Oh well... > I agree, I haven't added any function in this patch so I'm not sure it's appropriate to add comments within this patch. The statement I've moved is already commented. I can comment the function in a different patch. Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
