On Tue, 2008-08-05 at 14:50 +0200, Johannes Berg wrote: > On Tue, 2008-08-05 at 09:48 -0300, Henrique de Moraes Holschuh wrote: > > > Maybe on net/wireless, but I am really not going to trust that one for, > > e.g., serial and USB drivers (USB being a bus that is often not shut down > > during suspend because there are USB wake devices), unless you clearly state > > you DID review them all, and which ones. > > Look, this is _clearly_ the wrong thing to do, so unless you want your > patches blocked over it, just rip it out. You can of course keep the current _wrong_ behaviour of blocking the radio when suspending, but instead of adding extra API for the wake-on-wlan case you should work on fixing that. If you think that you then need to review all drivers, so be it. I don't think it makes sense because keeping the device alive requires additional code nobody in their right mind would write unless they knew they needed it, like libertas. As it stands, rfkill also does the wrong thing for rfkill. You don't have to fix it, of course, but don't add workarounds. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
