Am 19.08.19 um 22:09 schrieb Johannes Berg:
On Mon, 2019-08-19 at 22:03 +0200, Johannes Berg wrote:
While less desirable we still could get that working: The mvm driver
would have to detect the key borders and then tell the firmware to
switch over to the other key. But we would have to make sure to not
re-enable A-MPDU aggregation till the card really has switched.
So probably you're right, and we'd have to disable A-MPDUs until we have
no outstanding old-key-retransmits, but that seems manageable.
Actually, we probably have to even delay the key switch until there are
no more frames to retransmit, because the hardware is involved to some
extent and it won't know about two keys or something... Not really sure
how it all works though, off the top of my head.
This sounds like the card is not really able to handle two unicast key
per STA, which would be a show stopper.
But not sure if I can believe that: After all the card is setting the
correct keyid for the key and e.g. able to use keyid 1 for both send and
receive, so it's not simply assuming unicast keys are always using keyid 0.
Honoring the keyid for that but then not be able to differentiate
between the keyids for re-transmits is nothing I would have expected. So
I still hope you are wrong here:-)
Alexander
