Search Linux Wireless

Re: [PATCH] iwlwifi: Extended Key ID support for mvm and dvm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+
+	/* The new Tx API does not allow to pass the key or keyid of a MPDU to
+	 * the hw, preventing us to control which key(id) to use per MPDU.
+	 * Till that's fixed we can't use Extended Key ID for the newer cards.

Technically we still don't need per MPDU, we just need to switch which
one to use for TX after installing it for RX already.

The Extended Key ID API we finally merged in mac80211 is not notifying the driver when to switch the key over to the other id. The current API provides the key/keyid per MPDU and let's mac80211 have the full control what's the correct key for each frame.

That's especially critical for drivers setting IEEE80211_KEY_FLAG_GENERATE_IV and/or supporting A-MPDU's. Allowing the driver to override the mac80211 decision is only safe when the driver/card generates the PNs itself and also handles the A-MPDU key borders correctly.

While less desirable we still could get that working: The mvm driver would have to detect the key borders and then tell the firmware to switch over to the other key. But we would have to make sure to not re-enable A-MPDU aggregation till the card really has switched.

Alexander




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux