Am 19.08.19 um 22:23 schrieb Johannes Berg:
On Mon, 2019-08-19 at 17:52 +0200, Alexander Wetzel wrote:
We may also get away by adding only means to pass the keyid of the MPDU
(zero or one) to the HW. That could be done quite simple, I think:
We could add two new flags, e.g. IWL_TX_FLAGS_ENCRYPT_ID_0 and
IWL_TX_FLAGS_ENCRYPT_ID_1 to avoid the need to change the structures
iwl_tx_cmd_gen2 and iwl_tx_cmd_gen3.
When the firmware would check and use the key referenced by the STA +
flag-id prior to the "last installed" key that should be sufficient.
By still using the last installed key without any of the new flags set
we also would remain backward compatible.
If you have any experimental firmware to test I'm happy to do so:-)
Till then I'm back using older iwlwifi cards.
I'm not convinced that we can change the TX API at all, I suspect we
have to go detect it as we saw in the other patch. If we do actually
have the ability to change the TX API it might be simpler overall, but
anyway, I'd have to go look at how this is all implemented before I
comment further. Doesn't seem like an intractable problem, the only
question is if we get to spend time on it :)
You are thinking about keeping the tx API untouched and modify the key
install logic?
Just prevent the firmware to activate a key for Tx when it's installed
and notify the firmware by some means when the key can be used for Tx
and then switch everything to the new key?
I guess there is no practical way I can get access to the firmware code,
correct? For me it sounds harder than the optional flag extension I had
in mind for the new tx API.
After all one of the existing flags can already suppress the encryption.
Checking for the presence of two optional flags and use these to select
a different key sounded not very hard. But then I literally know nothing
about that and if the card/firmware has some fundamental issue handling
two unicast keys the picture changes of course...
So let's wait and see what you can turn up. Till then we have more than
enough other cards supporting Extended Key ID:-)
Alexander
