On Thu, 2019-04-25 at 16:44 +0800, Herbert Xu wrote: > On Thu, Apr 25, 2019 at 10:39:52AM +0200, Johannes Berg wrote: > > > > Yes, that's what I meant, it can only ever return NET_XMIT_SUCCESS or > > NET_XMIT_CN. This will not trigger the code you mentioned before though. > > You are right that it does not. However, the fact that this > congestion indication is lost is a bug rather than a feature. You can argue that way, I guess. However, *any* queue management algorithm that doesn't *solely* employ tail drops will necessarily behave this way. I would argue that you get better queue management if you don't solely rely on tail drops, so I'd rather pick better queue management than this (relatively obscure) congestion notification. The more commonly relevant socket buffer size will work for both. johannes
