On Thu, 2019-04-25 at 16:35 +0800, Herbert Xu wrote: > On Tue, Apr 23, 2019 at 02:41:33PM +0200, Johannes Berg wrote: > > > > I guess there might be value in returning NET_XMIT_CN anyway, but I > > think you're right in that we can never return anything but > > NET_XMIT_SUCCESS or NET_XMIT_CN since we never drop this new packet, > > just older ones. > > > > Which, btw, is exactly the same with net/sched/sch_fq_codel.c, AFAICT? > > Pretty sure codel does return NET_XMIT_CN. Yes, that's what I meant, it can only ever return NET_XMIT_SUCCESS or NET_XMIT_CN. This will not trigger the code you mentioned before though. johannes
