On Wed, 2008-07-23 at 12:27 -0300, Henrique de Moraes Holschuh wrote:
> On Wed, 23 Jul 2008, Johannes Berg wrote:
> > > + list_for_each_entry(p, &rfkill_list, node) {
> > > + if (p == rfkill)
> > > + return -EEXIST;
> > > + set_bit(p->type, &seen);
> >
> > You should WARN_ON so it can get fixed.
>
> I'd rather make rfkill_register __must_check, actually. With or without
> WARN_ON.
>
> In fact, lots of stuff in rfkill should be __must_check. Ivo, what do you
> think? Add __must_check? Add WARN_ON? Add both?
Do both then. __must_check annotations get ignored regularly, or
"handled" like this:
if (...)
// nothing we can do.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
