On Wed, 23 Jul 2008, Johannes Berg wrote:
> > + list_for_each_entry(p, &rfkill_list, node) {
> > + if (p == rfkill)
> > + return -EEXIST;
> > + set_bit(p->type, &seen);
>
> You should WARN_ON so it can get fixed.
I'd rather make rfkill_register __must_check, actually. With or without
WARN_ON.
In fact, lots of stuff in rfkill should be __must_check. Ivo, what do you
think? Add __must_check? Add WARN_ON? Add both?
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
