On Wed, 2008-07-23 at 18:22 +0200, Ivo van Doorn wrote: > On Wednesday 23 July 2008, Daniel Wagner wrote: > > It is not allowed to use NETDEV_TX_BUSY in tx path anymore. > > If not, then why is mac80211 checking and handling the return value > and is tx() still a function returning an int. mac80211 is actually requeueing > the frame when the hardware fails to send it, so why should that be completely blocked? Well, we want to remove that code from mac80211 because it's horribly ugly. But yes, if you stop queues it _should_ work. > > WARNING(rt2x00dev, "Failed to create RTS/CTS frame.\n"); > > - return NETDEV_TX_BUSY; > > + return -1; > > I am kind of missing the point here, this patch seems to come down to: > We can't return TX_BUSY so we return a random other value Yeah that's fishy. But I think this error code is just in this rts/cts function and getting handled in ->tx() johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
