On 12/10/2018, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: > On Fri, Oct 12, 2018 at 02:20:07PM +0200, Tom Psyborg wrote: >> > On upstream tree where this patch is intended >> > additional registers where never programmed as proper branch >> > were never used, because of additional check in RT5390 branch. >> > >> >> on my hardware additional registers were programmed in regardless of >> redundant check. that why i opened whole thread on forum since i >> couldn't understand how's that happening > > I don't understand how that possible either. i'd assume because device use external lna > >> > Patch does only change TX_SW_CFG* regs values for RT6352. >> > >> >> i'd still prefer that we include CONFIG_RT2800SOC, and if required >> move rest of the registers to that check, because at least on my >> hardware driver would still recognize chip as RT5390 despite the >> RT6352 defines > > As I pointed before you should add additional printk's and provide > dmesg to make us see what is going on. sorry,my hardware is broken, maybe somebody else could provide us with additional printks
