On 12/10/2018, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: > Please stop top-posting. > > On Fri, Oct 12, 2018 at 01:51:00PM +0200, Tom Psyborg wrote: >> it will cause regression on other devices > > How exactly ? the same way your wifi works without TX_SW_CFG entries and mine doesn't, while both are RT6352 > On upstream tree where this patch is intended > additional registers where never programmed as proper branch > were never used, because of additional check in RT5390 branch. > on my hardware additional registers were programmed in regardless of redundant check. that why i opened whole thread on forum since i couldn't understand how's that happening > Patch does only change TX_SW_CFG* regs values for RT6352. > i'd still prefer that we include CONFIG_RT2800SOC, and if required move rest of the registers to that check, because at least on my hardware driver would still recognize chip as RT5390 despite the RT6352 defines
