Search Linux Wireless

Re: [PATCH 1/3] mac80211: Include sequence number in IBSS and Mesh beacons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 09 July 2008, Johannes Berg wrote:
> On Wed, 2008-07-09 at 18:12 +0200, Ivo van Doorn wrote:
> 
> > > I'll put off the fix until after davem's TX MQ rework though.
> 
> Actually, I don't have to.
> 
> > Ok, that would allow some time for rt2x00 to come up with the
> > implementation for the rt2400pci and rt2500pci drivers.
> > 
> > And this is extra motivation for a volunteer to look into this,
> > because when mac80211 removes the seq counting, it is not
> > just adhoc and master mode that are broken. ;)
> 
> Here's a patch to try it out:
> 
> http://johannes.sipsolutions.net/patches/kernel/all/2008-07-09-17%3a38/022-mac80211-fix-hwseq.patch

Personally I have my doubts about the meaningfullness of the flag
	IEEE80211_TX_CTL_QOS_FRAME
since drivers will probably use ieee80211_is_data_qos() instead.
Perhaps it is better to have the flag named something like:
	IEEE80211_TX_CTS_SW_SEQUENCE
or
	IEEE80211_TX_CTS_HAS_SEQUENCE

That way it is a bit clearer what the intention of the flag is.

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux