On Wednesday 09 July 2008, Johannes Berg wrote: > On Wed, 2008-07-09 at 17:49 +0200, Johannes Berg wrote: > > > Ok so the thing is this: 802.11-2007 7.1.3.4.1 requires that we keep > > sequence counters per TID (and one for "not QoS"), which we only assign > > rather late in the wme code. Because even b43 hardware only keeps track > > of a single sequence counter, it requires not using that counter for QoS > > frames. I suspect no driver except the overly smart iwlwifi gets this > > right. > > Even if we fix this, we still haven't solved the problem of the beacon > sequence number. I'm currently favouring putting the burden on the > driver since only rt2400pci and rt2500pci seem to require it and it's > fairly simple to keep a race-free per-VIF counter for non-QoS frames in > the driver (you can just do it under the queue lock), but doing it > race-free in mac80211 will need a bunch of extra locking. > > I'll put off the fix until after davem's TX MQ rework though. Ok, that would allow some time for rt2x00 to come up with the implementation for the rt2400pci and rt2500pci drivers. And this is extra motivation for a volunteer to look into this, because when mac80211 removes the seq counting, it is not just adhoc and master mode that are broken. ;) Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
