On Thu, Jun 14, 2018 at 05:09:04PM +0300, Kalle Valo wrote: > Niklas Cassel <niklas.cassel@xxxxxxxxxx> writes: > > > On Tue, Jun 12, 2018 at 02:44:03PM +0200, Niklas Cassel wrote: > >> On Tue, Jun 12, 2018 at 06:02:48PM +0530, Govind Singh wrote: > >> > On 2018-06-12 17:45, Govind Singh wrote: > >> > > > >> > > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > >> > > > >> > > Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxxxxx> > >> > > --- > >> > > drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- > >> > > 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > > >> > > diff --git a/drivers/net/wireless/ath/ath10k/Kconfig > >> > > b/drivers/net/wireless/ath/ath10k/Kconfig > >> > > index 54ff5930126c..6572a43590a8 100644 > >> > > --- a/drivers/net/wireless/ath/ath10k/Kconfig > >> > > +++ b/drivers/net/wireless/ath/ath10k/Kconfig > >> > > @@ -42,7 +42,8 @@ config ATH10K_USB > >> > > > >> > > config ATH10K_SNOC > >> > > tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" > >> > > - depends on ATH10K && ARCH_QCOM > >> > > + depends on ATH10K > >> > > + depends on ARCH_QCOM || COMPILE_TEST > >> > > ---help--- > >> > > This module adds support for integrated WCN3990 chip connected > >> > > to system NOC(SNOC). Currently work in progress and will not > >> > > >> > Thanks Niklas for enabling COMPILE_TEST. With QMI set of > >> > changes(https://patchwork.kernel.org/patch/10448183/), we need to enable > >> > COMPILE_TEST for > >> > QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix the > >> > same. > > > > This patch is good as is. > > > > However, Govind's QMI patch set together with this patch > > resulted in build errors. > > > > FTR, these are fixed by: > > https://marc.info/?l=linux-kernel&m=152880985402356 > > https://marc.info/?l=linux-kernel&m=152889452326350 > > So the problem is that if I apply this patch I can't apply Govind's QMI > patchset (due to the build problems) until Niklas' fixes to qcom and > rpmsg subsystems propogate back to my tree and that might take weeks, or > even months. But I really would like to apply the QMI patchset ASAP so > that we can complete the wcn3990 support and not unnecessarily delay it. > > So what I propose is that I put this patch 2 as 'Awaiting Upstream' in > patchwork and apply it once Niklas' patches get to my tree. Does that > sound good? Absolutely. I didn't realize this until after sending the patch. Kind regards, Niklas
