On Tue, Jun 12, 2018 at 02:44:03PM +0200, Niklas Cassel wrote: > On Tue, Jun 12, 2018 at 06:02:48PM +0530, Govind Singh wrote: > > On 2018-06-12 17:45, Govind Singh wrote: > > > -----Original Message----- > > > From: ath10k <ath10k-bounces@xxxxxxxxxxxxxxxxxxx> On Behalf Of Niklas > > > Cassel > > > Sent: Tuesday, June 12, 2018 5:09 PM > > > To: Kalle Valo <kvalo@xxxxxxxxxxxxxx>; David S. Miller > > > <davem@xxxxxxxxxxxxx> > > > Cc: Niklas Cassel <niklas.cassel@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; > > > linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > > ath10k@xxxxxxxxxxxxxxxxxxx > > > Subject: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST > > > > > > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > > > > > > Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxxxxx> > > > --- > > > drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/wireless/ath/ath10k/Kconfig > > > b/drivers/net/wireless/ath/ath10k/Kconfig > > > index 54ff5930126c..6572a43590a8 100644 > > > --- a/drivers/net/wireless/ath/ath10k/Kconfig > > > +++ b/drivers/net/wireless/ath/ath10k/Kconfig > > > @@ -42,7 +42,8 @@ config ATH10K_USB > > > > > > config ATH10K_SNOC > > > tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" > > > - depends on ATH10K && ARCH_QCOM > > > + depends on ATH10K > > > + depends on ARCH_QCOM || COMPILE_TEST > > > ---help--- > > > This module adds support for integrated WCN3990 chip connected > > > to system NOC(SNOC). Currently work in progress and will not > > > > Thanks Niklas for enabling COMPILE_TEST. With QMI set of > > changes(https://patchwork.kernel.org/patch/10448183/), we need to enable > > COMPILE_TEST for > > QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix the > > same. > > This patch is good as is. However, Govind's QMI patch set together with this patch resulted in build errors. FTR, these are fixed by: https://marc.info/?l=linux-kernel&m=152880985402356 https://marc.info/?l=linux-kernel&m=152889452326350 Regards, Niklas
