On Tue, Jul 8, 2008 at 1:44 AM, Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote: > On Tue, 2008-07-08 at 01:16 +0300, Tomas Winkler wrote: >> On Tue, Jul 8, 2008 at 12:43 AM, Harvey Harrison >> > set. >> > >> I know but, what you missing is the check above. we bail out from the >> function if the packet is not qos data before so it's not relevant for >> checking >> of any null data just qos null data. I didn't want to touch the PS >> code that's why we've created a special handler for this particular >> case. >> I think you patch works as well and maybe can be used PS mode as >> well but I'm not sure now.. I will look at this alter. >> Tomas >> > > Good point, a helper probably isn't right for this as it's already been > checked that it's a data packet with qos, so opencoding the nullfunc > test is probably the right thing (as it was before my change). > > if (unlikely(hdr->frame_control & cpu_to_le16(IEEE80211_STYPE_NULLFUNC))) > > Cheers, Sound reasonable will drop this patch in favor of the open code. Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
