On Mon, Jul 7, 2008 at 10:26 PM, Harvey Harrison<harvey.harrison@xxxxxxxxx> wrote:> On Mon, 2008-07-07 at 19:02 +0200, Michael Buesch wrote:>> On Monday 07 July 2008 18:23:44 Harvey Harrison wrote:>> > On Mon, 2008-07-07 at 15:48 +0300, Tomas Winkler wrote:>> > > From: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>>> > >>> > > This patch fixes the check at the entrance to ieee80211_rx_reorder_ampdu.>> > > This check has been broken by 511fe3f3c4ba0b5b77421336f64a19b6cd00e65f>> > > 'mac80211: rx.c use new helpers'>> > >>> > Actually, do we want something like this instead:>> >>> Or, after having a coffee and actually engaging brain (similar to> ieee80211_is_data_qos)>> int ieee80211_is_data_nullfunc(__le16 fc)> {> return (fc & cpu_to_le16(IEEE80211_FCTL_FTYPE | IEEE80211_STYPE_NULLFUNC)) ==> cpu_to_le16(IEEE80211_FTYPE_DATA | IEEE80211_STYPE_NULLFUNC);> }>> Tomas, you want a patch?>> Harvey Maybe it's the late hour but I'm not sure what is wrong with theEmmanuel's patch. Mostly it fixes big stall in RX.Checked and validated.ThanksTomas��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f