Michael Nazzareno Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> writes:
>> @@ -315,15 +319,17 @@ static ssize_t dynamic_fw_traces_write(struct file *file,
>> if (unlikely(wl->state != WLCORE_STATE_ON))
>> goto out;
>>
>> - ret = wl1271_ps_elp_wakeup(wl);
>> - if (ret < 0)
>> + ret = pm_runtime_get_sync(wl->dev);
>> + if (ret < 0) {
>> + pm_runtime_put_noidle(wl->dev);
>> goto out;
>> + }
>>
>
> Can you just change ps_elp_wakeup with
> ret = pm_runtime_get_sync(wl->dev);
> if (ret < 0) {
> pm_runtime_put_noidle(wl->dev);
> goto out;
> }
>
>> ret = wl18xx_acx_dynamic_fw_traces(wl);
>> if (ret < 0)
>> count = ret;
>>
>> - wl1271_ps_elp_sleep(wl);
>> + pm_runtime_put(wl->dev);
>
> and elp_sleep with this one
>
>> out:
>> mutex_unlock(&wl->mutex);
>> return count;
>> @@ -374,9 +380,11 @@ static ssize_t radar_debug_mode_write(struct file *file,
>> if (unlikely(wl->state != WLCORE_STATE_ON))
>> goto out;
>>
>> - ret = wl1271_ps_elp_wakeup(wl);
>> - if (ret < 0)
>> + ret = pm_runtime_get_sync(wl->dev);
>> + if (ret < 0) {
>> + pm_runtime_put_noidle(wl->dev);
>> goto out;
>> + }
>>
>> wl12xx_for_each_wlvif_ap(wl, wlvif) {
>> wlcore_cmd_generic_cfg(wl, wlvif,
>> @@ -384,7 +392,7 @@ static ssize_t radar_debug_mode_write(struct file *file,
>> wl->radar_debug_mode, 0);
>> }
>>
>> - wl1271_ps_elp_sleep(wl);
>> + pm_runtime_put(wl->dev);
>
> Michael
<over 1600 lines of unnecessary quotation cut out>
PLEASE edit your quotes, your behaviour makes use of patchwork really
annoying:
https://patchwork.kernel.org/patch/10401591/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#do_not_top_post_and_edit_your_quotes
--
Kalle Valo
