(adding back lists) Sebastian Gottschall <s.gottschall@xxxxxxxxxx> writes: > Am 06.04.2018 um 10:25 schrieb Kalle Valo: >> Sebastian Gottschall <s.gottschall@xxxxxxxxxx> writes: >> >>> Am 06.04.2018 um 10:09 schrieb Kalle Valo: >>>> (adding back the lists, please don't top post and trim your quotes) >>>> >>>> Sebastian Gottschall <s.gottschall@xxxxxxxxxx> writes: >>>> >>>>> okay. ath10k-check is buggy and doesnt work. so it doesnt help much >>>>> with code styles >>>>> >>>>> root@seg-desktop:/xfs/ath10k/ath.gpio# ./ath10k-check >>>>> global: 'drivers/net/wireless/ath/ath10k/Kconfig' is not a source file. >>>>> Traceback (most recent call last): >>>>> File "./ath10k-check", line 461, in <module> >>>>> main() >>>>> File "./ath10k-check", line 455, in main >>>>> ret = run_checkpatch(args) >>>>> File "./ath10k-check", line 275, in run_checkpatch >>>>> output = subprocess.check_output(cmd, shell=True) >>>>> File "/usr/lib/python2.7/subprocess.py", line 219, in check_output >>>>> raise CalledProcessError(retcode, cmd, output=output) >>>>> subprocess.CalledProcessError: Command 'global -f >>>>> drivers/net/wireless/ath/ath10k/Kconfig' returned non-zero exit status 1 >>>> You are missing gtags, see 'ath10k-check --help' for how to install: >>>> >>>> Requirements (all available in $PATH): >>>> >>>> * gcc >>>> * sparse >>>> * checkpatch.pl >>>> * gtags (from package global) >>> ahm i did read this and this was all installed. but ath10k-check >>> refuses to work >>> >>> root@seg-desktop:/home/seg/DEV# gtags --version >>> gtags (GNU GLOBAL) 6.5.7 >>> Copyright (c) 1996-2017 Tama Communications Corporation >>> License GPLv3+: GNU GPL version 3 or later >>> <http://www.gnu.org/licenses/gpl.html> >>> This is free software; you are free to change and redistribute it. >>> There is NO WARRANTY, to the extent permitted by law. >> Damn, I guess something has changed in gtags as I use older version: >> >> gtags - GNU GLOBAL 5.7.1 > > okay. i will try to use a older version and see what happens You can also run checkpatch manually (sorry for the long line): checkpatch.pl --strict -q --terse --no-summary --max-line-length=90 --show-types --ignore MSLEEP,USLEEP_RANGE,PRINTK_WITHOUT_KERN_LEVEL,NETWORKING_BLOCK_COMMENT_STYLE,LINUX_VERSION_CODE,COMPLEX_MACRO,PREFER_DEV_LEVEL,PREFER_PR_LEVEL,COMPARISON_TO_NULL,BIT_MACRO,CONSTANT_COMPARISON,MACRO_WITH_FLOW_CONTROL,CONST_STRUCT,MACRO_ARG_REUSE,MACRO_ARG_PRECEDENCE foo.patch I modified ath10k-check --help to print the full commandline, just haven't pushed it out yet. -- Kalle Valo
