Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: > On 4/6/2018 10:37 AM, Dan Carpenter wrote: >> The issue here is that we allocate "data" and then set >> "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer >> instead of the original pointer. >> >> kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or >> more on everything except certain Xtensa variants. We decided that if >> the Xtensa people ever notice a bug here then we'll tell them the bug is >> on their side. ;) > > I am not sure if it was decided to be a xtensa bug, but just to ignore > the issue until it would arise. IIRC on other architectures the allocation is already aligned properly so there shouldn't be any functional changes with this patch, expect on xtensa of course. > Anyway, not sure if the last sentence is useful in the commit message. IMHO it is useful as it gives a summary of our discussion, just with a humorous tone :) -- Kalle Valo
