Sebastian Gottschall <s.gottschall@xxxxxxxxxx> writes: > Am 05.04.2018 um 16:44 schrieb Kalle Valo: >> s.gottschall@xxxxxxxxxx writes: >> >>> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 >>> based chipsets with on chipset connected led's using WMI Firmware API. >>> The LED device will get available named as "ath10k-phyX" at sysfs and >>> can be controlled with various triggers. adds also debugfs interface >>> for gpio control. >>> >>> Signed-off-by: Sebastian Gottschall <s.gottschall@xxxxxxxxxx> >> [...] >> >>> @@ -1034,7 +1068,7 @@ ath10k_wmi_pdev_get_temperature(struct ath10k *ar) >>> if (IS_ERR(skb)) >>> return PTR_ERR(skb); >>> - return ath10k_wmi_cmd_send(ar, skb, >>> + return ath10k_wmi_cmd_send_nowait(ar, skb, >>> ar->wmi.cmd->pdev_get_temperature_cmdid); >>> } >> This looks odd, I don't think it belongs to this patch. > > thats true. but due the nature of this function i found it better to > use nowait here. better if i split it up? Yes, this should be done in a separate patch with a proper commit log explaining why it's needed. >> Also you made a some sort of record, your patch had 181 checkpatch >> warnings! Do you use Word as your editor or what? But please do check >> your editor settings and read the coding style documents. > > no? i use midnight commander for all of my code since more than 20 years > and its the first time that i see such warnings. is there any special > coding rule for ath10k which differs from the kernel rules? You got even the indentation wrong in multiple functions and indentation rules have been the same as long as I remember. And checkpatch has been around a long time already, that should not be new to anyone submitting patches. > and where is ath10k-check located? Check the link I provided: >> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle -- Kalle Valo
