Re: [PATCH v5] rtlwifi: Replace hardcode value with macro

[Larry Finger <Larry.Finger@xxxxxxxxxxxx>]

On 08/02/2017 07:29 AM, Souptick Joarder wrote:
> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
> and hw->max_rate_tries are replaced by macro and removed the comment.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>

Finally!

Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

@Kalle: I'm sure you can work around this, but patchwork shows two different 
"v5" versions and a "v4" entry for this same patch. That may be due to no one 
formally rejecting the patch.

Larry

> ---
>   drivers/net/wireless/realtek/rtlwifi/base.c | 5 ++---
>   drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
>   2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index 8b833e2..ea18aa7 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -426,9 +426,8 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
>   	hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>   
>   	/* TODO: Correct this value for our hw */
> -	/* TODO: define these hard code value */
> -	hw->max_listen_interval = 10;
> -	hw->max_rate_tries = 4;
> +	hw->max_listen_interval = MAX_LISTEN_INTERVAL;
> +	hw->max_rate_tries = MAX_RATE_TRIES;
>   	/* hw->max_rates = 1; */
>   	hw->sta_data_size = sizeof(struct rtl_sta_info);
>   
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h b/drivers/net/wireless/realtek/rtlwifi/base.h
> index ab7d819..b56d1b7 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.h
> @@ -65,6 +65,8 @@ enum ap_peer {
>   #define FRAME_OFFSET_ADDRESS3		16
>   #define FRAME_OFFSET_SEQUENCE		22
>   #define FRAME_OFFSET_ADDRESS4		24
> +#define MAX_LISTEN_INTERVAL		10
> +#define MAX_RATE_TRIES			4
>   
>   #define SET_80211_HDR_FRAME_CONTROL(_hdr, _val)		\
>   	WRITEEF2BYTE(_hdr, _val)