Search Linux Wireless

Re: [PATCH v5] rtlwifi: Replace hardcode value with macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes:

> On 08/02/2017 07:29 AM, Souptick Joarder wrote:
>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
>> and hw->max_rate_tries are replaced by macro and removed the comment.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>
> Finally!
>
> Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
>
> @Kalle: I'm sure you can work around this, but patchwork shows two
> different "v5" versions and a "v4" entry for this same patch. That may
> be due to no one formally rejecting the patch.

It's because Souptick submitted two v5 patches, but yeah I can that sort
it out.

Souptick, the idea with patch versions is that maintainers and reviewers
can easily find the latest version and drop the rest so ALWAYS increase
the version number. Submitting duplicate version numbers defeats the
purpose and creates extra work for others.

-- 
Kalle Valo



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux