I traced through this code during MMIC failure and ieee80211_rx_h_decrypt() drops the frame before getting to ieee80211_rx_h_michael_mic_verify(). Johannes suggested this change to me in response to a previous thread and I am offering this patch after having conducted the proper testing on it. On Wed, Aug 2, 2017 at 9:43 AM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > >> On Wed, 2017-08-02 at 09:01 +0200, Stanislaw Gruszka wrote: >> >>> The relevant mac80211 code look like this: >>> >>> ieee80211_rx_result >>> ieee80211_rx_h_michael_mic_verify(struct ieee80211_rx_data *rx) >> >> I believe that ieee80211_rx_h_decrypt() will drop the frames you're >> looking at, and I do think the original patch is correct. If MMIC >> validation was (and could be) done, then the frame must have been >> decrypted properly. > > Just to avoid any confusion, with original patch you mean this one? > > rt2x00: Fix MMIC countermeasures. > https://patchwork.kernel.org/patch/9875647/ > > -- > Kalle Valo