Search Linux Wireless

Re: [RFC 3/2] get rid of rx handler function pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > #define CALL_RXH(rxh) if ((res = rxh(rx)) != RX_CONTINUE) goto rxh_done;
> 
> Would it really be so bad to just open-code them rather than the macro approach?
> 
> 	res = ieee80211_rx_h_passive_scan(rx);
> 	if (res != RX_CONTINUE) goto rxh_done;
> 
> 	res = ieee80211_rx_h_check(rx);
> 	if (res != RX_CONTINUE) goto rxh_done;
> 
> 	...
> 
> 
> Similar comment for the transmit handler patch.  

Well, I was lazy, and figured it'd be easier to add new ones that way if
needed.

> Either way, the approach looks good,
> and the size reduction is nice.

:)

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux