On Fri, 2017-06-02 at 13:19 +0200, Arend van Spriel wrote: > I was thinking about adding a DOC section in nl80211.h: Sure! > /** > * DOC: WPA/WPA2 temporal key exchange offload > * > * By setting @NL80211_EXT_FEATURE_4WAY_HANDSHAKE_STA_PSK flag > drivers > * can indicate offload support of EAPOL handshakes for WPA/WPA2 can indicate they support offloading EAPOL ...? > * preshared key authentication. In %NL80211_CMD_CONNECT the > preshared > * key should be specified using %NL80211_ATTR_PMK. Drivers > supporting > * this offload may reject the %NL80211_CMD_CONNECT when no > preshared > * key material is provided. For example when that driver does not > * support setting the temporal keys through %NL80211_CMD_NEW_KEY. [...] is provided, for example when [...] I think? Starting with "For example" seems odd to me. > * > * Similarly @NL80211_EXT_FEATURE_4WAY_HANDSHAKE_STA_1X flag can be > * set by drivers indicating offload support of the PTK/GTK EAPOL > * handshakes during 802.1X authentication. In order to use the > offload > * the %NL80211_CMD_CONNECT should have > %NL80211_ATTR_WANT_1X_4WAY_HS > * attribute flag. Drivers supporting this offload may reject the > * %NL80211_CMD_CONNECT when the attribute flag is not present. > */ > > Could add description for FT, ie. PMK-R0 handling as well. Do you > think this change warrants a separate section or not. Any comments on > the text itself are welcome. I think that's good to have. johannes
