+ hostap list On 17-5-2017 16:19, Johannes Berg wrote: > Hi, > > I think this looks really good. One thing though: > >> Another change is the >> addition of the flag ATTR_WANT_1X_4WAY_HS that user-space has to pass >> in CONNECT request. Some drivers may need to be aware before the PMK >> is programmed through SET_PMK request. > > I wonder how we really should do this, and if this is good enough. > > There might be drivers that simply don't support the non-offloaded > case, so they assume you always have the newer wpa_s. That would seem > to be a legitimate decision, since the compatibility with that might > not make much sense for a completely new driver, and it might be a lot > of work to support TK operations. > > We should therefore probably set the expectation that wpa_s - if it's > new enough - always uses the offloaded functionality and always sets > the WANT_1X. Then this is even better with such drivers, since they can > immediately reject the connect() command if want_1x isn't set. > > Thoughts? Personally I am fine with this and it is how I tested it. So no network configuration or driver parameter in wpa_s.conf (mainly because I am lazy ;-) ). However, if the driver supports both offload and non-offload why not leave it up to user-space. Might be useful if people can try either way for example when debugging connection issues. Regards, Arend
