On Thu, 2017-05-18 at 14:48 +0200, Arend Van Spriel wrote: > True. However, we touched this topic a while ago in generic context, > ie. preference for ext_features over supported_commands. Right now > wpa_supplicant does not check NEW_KEY support so we can go either > way. Right. That's a separate discussion though - whether we add two flags here or check NEW_KEY support doesn't really matter, except that we need to decide * if we want to support such an override at all, and * if it should be tested at all (perhaps we can just live with that failing entirely?) > I have cleaned up the wpa_supplicant patches for the offloads, but > waited with submitting them until the kernel side got applied. So > depending on what is decided here I can rework it. I don't really know. I personally don't think that we need to allow both ways, but then I'm coming with a driver that doesn't even support the old way. So you should probably decide yourself if you want to keep this fallback option, and how well it should work (be rejected if used on a driver that doesn't support it, or just fail later?) johannes
