On 1/2/2017 12:45 PM, Johannes Berg wrote: > On Mon, 2016-12-19 at 12:58 +0200, Lazar, Alexei Avshalom wrote: > >>> What you're doing here is *extremely* vague. No definitions of what >>> this means, no description of how it's intended to be implemented, >>> no note even on whether or not this is for full-MAC chips or not, >>> etc. >>> >> >> The patch is intended for full-MAC chips and I will update the commit >> message to include more details. >> >>> At least for mac80211, we can define signals to userspace regarding >>> "link quality" and make decisions in wpa_s then? >>> >> >> The policy is offloaded today to the FW and the decision being made >> by the FW. >> We are only modifying the behavior and not making the decision. > > Fair enough, but I stand by saying that it's extremely vague - how > could userspace possibly know what "level" to pick, if you don't give > it any information about what the levels really mean? > > johannes > I have updated the commit message for clarifying what the levels really mean. -- Alexei Lazar Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum a Linux Foundation Collaborative Project