> OK, just for clarity, could you spell out the helper names you'd like to > see, and I'll adjust accordingly, at this point I think you would agree > with: > > ieee80211_is_data > ieee80211_is_ctl > ieee80211_is_mgmt > > ieee80211_has_protected > ieee80211_has_morefrags > ieee80211_has_tods > ieee80211_has_fromds > ieee80211_has_a4 > > And you'd like to see the following changes: > > ieee80211_data_has_qos -> ieee80211_is_data_qos (maybe dataqos) > ieee80211_ctl_is_ack -> ieee80211_is_ack > ieee80211_ctl_is_pspoll -> ieee80211_is_pspoll > ieee80211_ctl_is_back_req -> ieee80211_is_back_req > ieee80211_mgmt_is_beacon -> ieee80211_is_beacon > > I agree that does look nicer, and it just has to be clear that these > explicity check the ftype as well. > So choose a colour for the bikeshed and I'll get painting ;-) Heh. Yeah those above seem fine to me. Arguably, "has_protected" sounds a bit weird, but I'm not going to argue that, let's just do it. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
