On Mon, 2008-06-09 at 10:43 -0700, Harvey Harrison wrote: > On Mon, 2008-06-09 at 19:21 +0200, Johannes Berg wrote: > > On Mon, 2008-06-09 at 09:31 -0700, Harvey Harrison wrote: > > > > > > As this helper only checks for the one bit being set, I chose _has_. > > > > Hmm. As far as I can tell, it checks that the frame is a QoS controlled > > data frame. Hence, it explicitly checks that it _is_ a data frame and > > _has_ the QoS bit, but in 802.11 lingo I think that means it _is_ a > > "data+qos" frame. > > > > Well, it's not a big deal...what name do you want and I'll change it. I'd prefer _is_qos_data because _data_has_qos makes me think I have to ensure that the frame is a data frame before passing it in, i.e. it will return undefined results for a management/control frame. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
