On Mon, 2008-06-09 at 19:46 +0200, Johannes Berg wrote: > On Mon, 2008-06-09 at 10:43 -0700, Harvey Harrison wrote: > > On Mon, 2008-06-09 at 19:21 +0200, Johannes Berg wrote: > > > On Mon, 2008-06-09 at 09:31 -0700, Harvey Harrison wrote: > > > > > > > > As this helper only checks for the one bit being set, I chose _has_. > > > > > > Hmm. As far as I can tell, it checks that the frame is a QoS controlled > > > data frame. Hence, it explicitly checks that it _is_ a data frame and > > > _has_ the QoS bit, but in 802.11 lingo I think that means it _is_ a > > > "data+qos" frame. > > > > > > > Well, it's not a big deal...what name do you want and I'll change it. > > I'd prefer _is_qos_data because _data_has_qos makes me think I have to > ensure that the frame is a data frame before passing it in, i.e. it will > return undefined results for a management/control frame. Well, the way the other functions of the same type: ieee80211_ctl_is_ack ieee80211_mgmt_is_beacon check not only that the ftype is exactly ctl/mgmt and that it is of stype ack/beacon. I chose ieee80211_data_has_qos because it checks the ftype _is_ data _and_ that it _has_ qos included. I think my naming is more consistent with this. Do you still think it should be changed? Cheers, Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
