Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > I don't have a problem with the ath debug printks. Larry asked me for > examples of better debug functions and the ath code is an example. > Literally, any existing debug functions are better than the > BTC_TRACE_STRING() stuff. Sure, I agree with that. My point was just that sometimes it's ok to have own logging wrappers and there's no hard rule for this. -- Kalle Valo