Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > On Wed, Dec 07, 2016 at 02:16:06PM +0200, Kalle Valo wrote: >> We have disccused this before, but for wireless it's not really that >> simple. AFAIK with dyndbg you can only control the messages per line >> (painful to enable group of messages) or per file (enables too many >> messages). In wireless we have cases when we need to enable group of >> messages, but not all. > > You can turn them on by the function or a range of lines, then disable > the spammy lines. With these new debug macros you can't do that so this > is a step backwards. >From my point of view dyndbg is step backwards. Line numbers change all the time and you can't have simple instructions like this for users and developers working with the driver: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/debug#debug_log_messages I don't want waste time with this anymore as we seem to just disagree. My point here was that in wireless we have used log wrappers before and will continue to use them in certain drivers as dyndbg is not enough. But it would make me very happy if someone would add a similar grouping functionality to dyndbg to make it easy to enable a set of debug messages in a driver. -- Kalle Valo
