I don't have a problem with the ath debug printks. Larry asked me for examples of better debug functions and the ath code is an example. Literally, any existing debug functions are better than the BTC_TRACE_STRING() stuff. On Thu, Dec 08, 2016 at 01:43:42PM +0200, Kalle Valo wrote: > But it would make me very happy if someone would add a similar grouping > functionality to dyndbg to make it easy to enable a set of debug > messages in a driver. Thats seems like a reasonable thing as well. regards, dan carpenter