> The rules when to check sa/da should be independent of the driver > and thus would likely be duplicated by each caller. This is why I > had it in ieee80211_amsdu_to_8023s. That does make sense, I guess. But I feel that it's overly complicated, and most drivers don't actually support all those features, in particular, 4-addr station/AP is currently exclusive to mac80211. > My patch defaulted into not checking sa/da for interface type not > explicitly given, whereas your code defaults to checking both for > those. > This makes a difference for IFTYPE_MONITOR, IFTYPE_P2P_*, Monitor will never get there, and P2P_CLIENT == STATION, P2P_GO == AP as far as mac80211's vif.type is concerned, so those are handled. > IFTYPE_OCB, That can't do A-MSDU I believe. > IFTYPE_UNSPECIFIED, That is invalid and can never happen here. > IFTYPE_WDS. This is ... it can't even negotiate HT, so I doubt A-MSDU could be used in any way. This is old crap, and I'd actually rather remove it, the 4- addr station/AP superseded it. > I don't know if filtering is appropiate > for those or if they can actually occur there. I think it's all covered then. Could you test my patches in your scenario to see they do what we want? I'll resend as [PATCH] then, and think about applying them and perhaps backporting also. johannes
