Am 05.10.2016 16:59, schrieb Johannes Berg:
So as you can see by my own version of this patch, I'm not super happy
with the way you did things here :)
I'm happy with your version, so lets just drop mine.
Instead of adding 4 new arguments, (ta, ra, is_4addr, is_tdls_data), I
opted to just add two (check_da and check_sa) and make those NULL when
no checks are desired.
I *think* that works equivalently, but it'd be great if you could take
a look.
The rules when to check sa/da should be independent of the driver and
thus would likely be duplicated by each caller.
This is why I had it in ieee80211_amsdu_to_8023s.
My patch defaulted into not checking sa/da for interface type not
explicitly given, whereas your code defaults to checking both for those.
This makes a difference for IFTYPE_MONITOR, IFTYPE_P2P_*, IFTYPE_OCB,
IFTYPE_UNSPECIFIED, IFTYPE_WDS. I don't know if filtering is appropiate
for those or if they can actually occur there.
This also conflicts with the earlier patch I sent to just always drop
when it's multicast.
Dropping multicast A-MSDU frames is fine for me.
michael
