Bartosz Markowski <bartosz.markowski@xxxxxxxxx> writes:
> On 14 September 2016 at 09:06, Valo, Kalle <kvalo@xxxxxxxxxxxxxxxx> wrote:
>>
>> Bartosz Markowski <bartosz.markowski@xxxxxxxxx> writes:
>>
>> > On 12 September 2016 at 17:35, Valo, Kalle <kvalo@xxxxxxxxxxxxxxxx> wrote:
>> >
>> >> > +#ifdef CONFIG_ACPI
>> >> > +#define WRD_METHOD "WRDD"
>> >> > +#define WRDD_WIFI (0x07)
>> >> > +
>> >> > +static u32 ath10k_mac_wrdd_get_mcc(struct ath10k *ar, union acpi_object *wrdd)
>> >> > +{
>> >>
>> >> I don't think the ifdef is really necessary, acpi.h should handle that
>> >> (hopefully). Also I changed the error handling to use standard error
>> >> values and changed the info messages to dbg, they are too spammy in my
>> >> opinion. Please check carefully my changes in the pending branch:
>> >>
>> >> https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=fe91745381ec3999d8de6dedb07b396c82539717
>> >
>> > I'm OK with the changes, I have not tried that though, except of
>> > reviewing and compiling it (do not have access to the chromebook for
>> > next few days). If you want to wait with it until I test it, it's fine
>> > too.
>>
>> Ok, I'll wait for few days in case you have time to test it.
>
>
> Sorry, it took so long. I've final check this and can confirm the patch.
Thanks, I'll apply the patch soon. Do note that I changed more of the
warnings messages to debug level.
--
Kalle Valo
