Bartosz Markowski <bartosz.markowski@xxxxxxxxx> writes: > This overrides whatever regulatory the device > EEPROM contains and uses what the platform says > instead - in this implementation the ACPI driver. > > In case the hint is not programmed or corrupted (0xffff) > the device falls back to the eeprom programmed settings. > > Signed-off-by: Bartosz Markowski <bartosz.markowski@xxxxxxxxx> [...] > +#ifdef CONFIG_ACPI > +#define WRD_METHOD "WRDD" > +#define WRDD_WIFI (0x07) > + > +static u32 ath10k_mac_wrdd_get_mcc(struct ath10k *ar, union acpi_object *wrdd) > +{ I don't think the ifdef is really necessary, acpi.h should handle that (hopefully). Also I changed the error handling to use standard error values and changed the info messages to dbg, they are too spammy in my opinion. Please check carefully my changes in the pending branch: https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=fe91745381ec3999d8de6dedb07b396c82539717 -- Kalle Valo